mirror of
https://github.com/actions/setup-java.git
synced 2026-07-08 22:31:49 +00:00
801240703e
The Git-bundled GPG on Windows (MSYS2-based) does not automatically convert Windows-style paths in environment variables like GNUPGHOME. This caused GPG to fail with exit code 2 when verifying Microsoft JDK signatures on Windows, because the GNUPGHOME path (D:\a\_temp\...) was not recognized as a valid POSIX path. Fix: pass --homedir as an explicit command-line argument to both gpg --import and gpg --verify. MSYS2 does correctly convert Windows paths in command-line arguments, so this approach works reliably on Windows, Linux, and macOS.
105 lines
2.6 KiB
TypeScript
105 lines
2.6 KiB
TypeScript
import * as path from 'path';
|
|
import * as io from '@actions/io';
|
|
import * as exec from '@actions/exec';
|
|
import * as tc from '@actions/tool-cache';
|
|
import * as gpg from '../src/gpg';
|
|
|
|
jest.mock('@actions/exec', () => {
|
|
return {
|
|
exec: jest.fn()
|
|
};
|
|
});
|
|
|
|
jest.mock('@actions/tool-cache', () => {
|
|
return {
|
|
downloadTool: jest.fn()
|
|
};
|
|
});
|
|
|
|
const tempDir = path.join(__dirname, 'runner', 'temp');
|
|
process.env['RUNNER_TEMP'] = tempDir;
|
|
|
|
describe('gpg tests', () => {
|
|
beforeEach(async () => {
|
|
await io.mkdirP(tempDir);
|
|
});
|
|
|
|
afterAll(async () => {
|
|
try {
|
|
await io.rmRF(tempDir);
|
|
} catch {
|
|
console.log('Failed to remove test directories');
|
|
}
|
|
});
|
|
|
|
describe('importKey', () => {
|
|
it('attempts to import private key and returns null key id on failure', async () => {
|
|
const privateKey = 'KEY CONTENTS';
|
|
const keyId = await gpg.importKey(privateKey);
|
|
|
|
expect(keyId).toBeNull();
|
|
|
|
expect(exec.exec).toHaveBeenCalledWith(
|
|
'gpg',
|
|
expect.anything(),
|
|
expect.anything()
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('deleteKey', () => {
|
|
it('deletes private key', async () => {
|
|
const keyId = 'asdfhjkl';
|
|
await gpg.deleteKey(keyId);
|
|
|
|
expect(exec.exec).toHaveBeenCalledWith(
|
|
'gpg',
|
|
expect.anything(),
|
|
expect.anything()
|
|
);
|
|
});
|
|
|
|
describe('verifyPackageSignature', () => {
|
|
it('imports bundled key and verifies package', async () => {
|
|
const publicKeyContent =
|
|
'-----BEGIN PGP PUBLIC KEY BLOCK-----\ntest\n-----END PGP PUBLIC KEY BLOCK-----';
|
|
(tc.downloadTool as jest.Mock).mockResolvedValue('/tmp/jdk.tar.gz.sig');
|
|
await gpg.verifyPackageSignature(
|
|
'/tmp/jdk.tar.gz',
|
|
'https://example.com/jdk.tar.gz.sig',
|
|
publicKeyContent
|
|
);
|
|
|
|
expect(tc.downloadTool).toHaveBeenCalledWith(
|
|
'https://example.com/jdk.tar.gz.sig'
|
|
);
|
|
expect(exec.exec).toHaveBeenNthCalledWith(
|
|
1,
|
|
'gpg',
|
|
[
|
|
'--homedir',
|
|
expect.any(String),
|
|
'--batch',
|
|
'--import',
|
|
expect.stringContaining('public-key.asc')
|
|
],
|
|
expect.objectContaining({silent: true})
|
|
);
|
|
expect(exec.exec).toHaveBeenNthCalledWith(
|
|
2,
|
|
'gpg',
|
|
[
|
|
'--homedir',
|
|
expect.any(String),
|
|
'--batch',
|
|
'--verify',
|
|
'/tmp/jdk.tar.gz.sig',
|
|
'/tmp/jdk.tar.gz'
|
|
],
|
|
expect.objectContaining({silent: true})
|
|
);
|
|
});
|
|
});
|
|
});
|
|
});
|