From d9e99fb8538a780dae216c72da3d7a1da8eb45d2 Mon Sep 17 00:00:00 2001 From: jmjaffe37 Date: Wed, 1 Jul 2026 11:16:55 -0700 Subject: [PATCH] Updated jetbrains https.request command to catch errors. This fixes leaking tests as well --- .../distributors/jetbrains-installer.test.ts | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/__tests__/distributors/jetbrains-installer.test.ts b/__tests__/distributors/jetbrains-installer.test.ts index bf1dc15d..d292e574 100644 --- a/__tests__/distributors/jetbrains-installer.test.ts +++ b/__tests__/distributors/jetbrains-installer.test.ts @@ -87,10 +87,20 @@ describe('findPackageForDownload', () => { const url = resolvedVersion.url; const options = {method: 'HEAD'}; - https.request(url, options, res => { - // JetBrains uses 403 for inexistent packages - expect(res.statusCode).not.toBe(403); - res.resume(); + await new Promise((resolve, reject) => { + const request = https.request(url, options, res => { + try { + // JetBrains uses 403 for non-existent packages + expect(res.statusCode).not.toBe(403); + res.resume(); + res.on('end', resolve); + } catch (error) { + reject(error); + } + }); + + request.on('error', reject); + request.end(); }); } );