From c41070eda4f4d598540a89ad4a0e333b2b5bba07 Mon Sep 17 00:00:00 2001 From: Shubham Tiwari <64764738+tiwarishub@users.noreply.github.com> Date: Thu, 31 Mar 2022 20:46:04 +0530 Subject: [PATCH 1/3] Update util.ts --- src/util.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util.ts b/src/util.ts index 588b3624..c7dfb79d 100644 --- a/src/util.ts +++ b/src/util.ts @@ -50,7 +50,7 @@ export function getDownloadArchiveExtension() { export function isVersionSatisfies(range: string, version: string): boolean { if (semver.valid(range)) { - // if full version with build digit is provided as a range (such as '1.2.3+4') + // Test if full version with build digit is provided as a range (such as '1.2.3+4') // we should check for exact equal via compareBuild // since semver.satisfies doesn't handle 4th digit const semRange = semver.parse(range); From efbea1411b18823f99d704f247a3090511af93db Mon Sep 17 00:00:00 2001 From: Shubham Tiwari <64764738+tiwarishub@users.noreply.github.com> Date: Thu, 31 Mar 2022 20:49:24 +0530 Subject: [PATCH 2/3] Update util.ts --- src/util.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util.ts b/src/util.ts index c7dfb79d..588b3624 100644 --- a/src/util.ts +++ b/src/util.ts @@ -50,7 +50,7 @@ export function getDownloadArchiveExtension() { export function isVersionSatisfies(range: string, version: string): boolean { if (semver.valid(range)) { - // Test if full version with build digit is provided as a range (such as '1.2.3+4') + // if full version with build digit is provided as a range (such as '1.2.3+4') // we should check for exact equal via compareBuild // since semver.satisfies doesn't handle 4th digit const semRange = semver.parse(range); From e886040dc21d1d2c3f71482e1b6518445ef5e620 Mon Sep 17 00:00:00 2001 From: Shubham Tiwari <64764738+tiwarishub@users.noreply.github.com> Date: Thu, 31 Mar 2022 22:03:52 +0530 Subject: [PATCH 3/3] Update zulu-installer.test.ts (#310) --- __tests__/distributors/zulu-installer.test.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/__tests__/distributors/zulu-installer.test.ts b/__tests__/distributors/zulu-installer.test.ts index 666cd90d..79a3389f 100644 --- a/__tests__/distributors/zulu-installer.test.ts +++ b/__tests__/distributors/zulu-installer.test.ts @@ -139,6 +139,7 @@ describe('findPackageForDownload', () => { packageType: 'jdk', checkLatest: false }); + distribution['getAvailableVersions'] = async () => manifestData; await expect( distribution['findPackageForDownload'](distribution['version']) ).rejects.toThrowError(/Could not find satisfied version for semver */);